-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): Add Github actions workflow for production deployment with manual approval #732
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YeagerAI-Bulat Have you tested the curl
request? I'm searching docs for this and I've found:
- https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch
- https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event
And none of them have the same syntax as the command you've pasted
Nit: could we use the gh cli as in https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#providing-inputs? I think it's easier to understand than curl
commands
gh workflow run run-tests.yml -f logLevel=warning -f tags=false -f environment=staging
-H "Accept: application/vnd.github.v3+json" \ | ||
-H "Authorization: token ${{ secrets.DEPLOYMENT_PAT }}" \ | ||
-H "Content-Type: application/json" \ | ||
https://api.github.com/repos/yeagerai/genlayer-studio/dispatches \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this point to the infra repo? like
https://api.github.com/repos/yeagerai/genlayer-studio/dispatches \ | |
https://api.github.com/repos/yeagerai/genlayer-simulator-infra/dispatches \ |
@YeagerAI-Bulat do we have a staging environment to also add the trigger for it? |
Fixes #731
What
Why
Testing done
Decisions made
I confirm
) in the workflow to prevent accidental deployments.Checks
Reviewing tips
User facing release notes