Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consensus deploy contract when finalized #712

Closed

Conversation

kstroobants
Copy link
Contributor

@kstroobants kstroobants commented Dec 10, 2024

Fixes #708

What

  • Redo the change so that the contract is deployed when the transaction is finalized. I could not find any other issue than the issue where the appeal window loop does not recover, that blocks the transaction to go to the finalized state.

Why

  • To fix a bug

Testing done

  • Tested the bug fix in the localhost and ran the consensus unit tests locally

Decisions made

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

Run studio and see code changes

User facing release notes

Contract is deployed when the transaction is in the finalized state after waiting for the finality window. The write methods will be accessible when the transaction is in the finalized state.

@kstroobants kstroobants self-assigned this Dec 10, 2024
@kstroobants kstroobants linked an issue Dec 10, 2024 that may be closed by this pull request
@kstroobants
Copy link
Contributor Author

I won't merge this PR before there is a user friendly solution in the main branch to change the finality window in .env or we put the default on a low number.

@kstroobants kstroobants deleted the 708-consensus-deploy-contract-in-when-finalized branch December 10, 2024 14:47
@kstroobants
Copy link
Contributor Author

Closed because it was implemented correctly.

When a transaction tx1 is sent to deploy an intelligent contract then from the accepted state you are able to submit the next transaction tx2 towards that intelligent contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consensus: deploy contract when finalized
1 participant