Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add number input for finality window #711

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

kstroobants
Copy link
Contributor

@kstroobants kstroobants commented Dec 10, 2024

Fixes #710

What

  • Added a field to the frontend to change the finality window of the appeal process

Why

  • To add more value to the user

Testing done

  • Tested the new feature on the webpage

Decisions made

I have put the field below the leader. Let me know if it is better to put it in the settings tab.
Screenshot 2024-12-10 at 08 28 30
Screenshot 2024-12-10 at 08 29 00
Screenshot 2024-12-10 at 08 28 48
Screenshot 2024-12-10 at 08 29 14

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

See code changes and run the studio.

User facing release notes

A number field is added to the frontend to change the finality window of the appeal process.

@kstroobants kstroobants self-assigned this Dec 10, 2024
@kstroobants kstroobants linked an issue Dec 10, 2024 that may be closed by this pull request
@kstroobants
Copy link
Contributor Author

@denishacquin Feel free to change the UI look.
@cristiam86 I don't know if this feature is good/bad for the online hosted studio. We should let Bulat know if he should disable access the the rpc method but then the field should also be disabled.

@kstroobants
Copy link
Contributor Author

@cristiam86 I don't know if this feature is good/bad for the online hosted studio. We should let Bulat know if he should disable access the the rpc method but then the field should also be disabled.

Added check in frontend field based on VITE_IS_HOSTED so it won't be shown in the hosted version. @YeagerAI-Bulat When hosting we should write a meaningful finality window in the .env.example file.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@kstroobants kstroobants merged commit 1c34cae into main Dec 10, 2024
10 of 11 checks passed
@kstroobants kstroobants deleted the 710-sim-fe-finality-window branch December 10, 2024 21:35
Copy link
Contributor

🎉 This PR is included in version 0.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIM-FE-Finality window
2 participants