Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adapt endpoint for genlayer js rpc #701

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: adapt endpoint for genlayer js rpc #701

merged 1 commit into from
Dec 9, 2024

Conversation

denishacquin
Copy link
Contributor

@denishacquin denishacquin commented Dec 9, 2024 •
edited
Loading

Fixes #699

What

  • pass the endpoint for genlayer RPC

Why

  • to have calls going through genlayer-js working on both environments

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

User facing release notes

  • Fixed genlayer-js RPC calls in hosted studio

@denishacquin denishacquin self-assigned this Dec 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@denishacquin denishacquin marked this pull request as ready for review December 9, 2024 07:27
@cristiam86 cristiam86 merged commit d46aa3f into main Dec 9, 2024
24 of 28 checks passed
@cristiam86 cristiam86 deleted the denis/699-fix-endpoint-url branch December 9, 2024 13:40
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 0.28.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiam86 cristiam86 cristiam86 approved these changes

Assignees

@denishacquin denishacquin

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calls in hosted studio are going to local network
2 participants
@denishacquin @cristiam86