Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: frontend build gh action #678

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

denishacquin
Copy link
Contributor

@denishacquin denishacquin commented Dec 4, 2024

Fixes #677

What

  • added frontend build to gh actions

Why

  • to make sure the frontend can build before we merge any branch

Testing done

N/A

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

User facing release notes

@denishacquin denishacquin linked an issue Dec 4, 2024 that may be closed by this pull request
@denishacquin denishacquin self-assigned this Dec 4, 2024
Copy link

sonarqubecloud bot commented Dec 4, 2024

@denishacquin
Copy link
Contributor Author

Would this make sense to you @cristiam86 ?

@cristiam86
Copy link
Collaborator

Would this make sense to you @cristiam86 ?

yes, it makes sense. But aren't we already running frontend unit tests in the other workflows?

@denishacquin
Copy link
Contributor Author

Would this make sense to you @cristiam86 ?

yes, it makes sense. But aren't we already running frontend unit tests in the other workflows?

Those are separate. I just ran unit tests locally and they succeed while the build fail.

@cristiam86
Copy link
Collaborator

Would this make sense to you @cristiam86 ?

yes, it makes sense. But aren't we already running frontend unit tests in the other workflows?

Those are separate. I just ran unit tests locally and they succeed while the build fail.

Yeah, the build part I get it, but in your action, you are also running the unit test in the front end: https://github.com/yeagerai/genlayer-studio/pull/678/files#diff-99e3486466e938171924bf1a5ede5aed83ee1548ece94123968ede576189e266R35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test frontend build via github actions
2 participants