Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make the studio storage reset actually clean everything #648

Merged
merged 14 commits into from
Dec 2, 2024

Conversation

denishacquin
Copy link
Contributor

@denishacquin denishacquin commented Nov 26, 2024

Fixes #616

What

  • Resetting the storage now resets all txs, contracts and deployments for local storage and local db, as well as tx socket subscriptions
image
  • Added a download button in the contract files for more easily saving files
image
  • Fixed: the "go to settings" link in a contract when zero validators -> now "go to validators"
image
  • Fixed: missing "No parameters" empty state placeholder in constructor params when no params detected
image

Why

  • To allow people to really clean their storage especially when sth breaks
  • To allow people to save a file easily before resetting everything
  • To fix small bugs

Testing done

  • tested the new feature and bug fixes
  • fixed some linting
  • units frontend OK
  • e2e OK

Decisions made

  • Decided to add a download button on files

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

User facing release notes

  • The Reset storage feature now actually resets everything stored locally (contracts, transactions, deployments)
  • Added a Download button on contract files to easily save your work (useful if you want to reset everything)
  • Fixed some minor issues

@denishacquin denishacquin linked an issue Nov 26, 2024 that may be closed by this pull request
@denishacquin denishacquin self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 60 lines in your changes missing coverage. Please review.

Project coverage is 19.31%. Comparing base (b09dfed) to head (3cdb63a).

Files with missing lines Patch % Lines
...components/Simulator/settings/SimulatorSection.vue 0.00% 31 Missing ⚠️
frontend/src/components/Simulator/ContractItem.vue 0.00% 21 Missing ⚠️
...ontend/src/components/Simulator/ContractParams.vue 0.00% 6 Missing ⚠️
frontend/src/components/Simulator/ContractInfo.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
- Coverage   19.55%   19.31%   -0.25%     
==========================================
  Files         129      129              
  Lines       10006    10002       -4     
  Branches      319      311       -8     
==========================================
- Hits         1957     1932      -25     
- Misses       7964     7985      +21     
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denishacquin denishacquin marked this pull request as ready for review November 26, 2024 13:34
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@denishacquin denishacquin merged commit 1fe8654 into main Dec 2, 2024
14 of 16 checks passed
@cristiam86 cristiam86 mentioned this pull request Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

🎉 This PR is included in version 0.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@cristiam86 cristiam86 deleted the 616-reset-storage-button-confusion branch December 9, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset storage button confusion
2 participants