Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: appeals implement sequential appeals fail #637

Merged
merged 24 commits into from
Dec 17, 2024
Merged

fix: appeals implement sequential appeals fail #637

merged 24 commits into from
Dec 17, 2024

Conversation

kstroobants
Copy link
Contributor

@kstroobants kstroobants commented Nov 25, 2024 •
edited
Loading

Fixes #604

What

  • Add appeal_failed to Transactions in the database
  • Select new validators when appealed based on formula, see issue.
  • Clean up consensus mechanism base file

Why

  • To fix a bug when selecting the number of validators when multiple appeal fails sequentially
  • To add more value to the user

Testing done

  • Tested the new feature in the simulator
  • Added tests to the test_base.py

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

  • Run simulator
  • Run tests/unit/consensus/test_base.py

@kstroobants
feat: add rollup transaction db table
021f10e
@kstroobants
fix: drop audit table, change id and nonce of rollup, only make one f…
eca17e5 
…inalized rollup transaction
@kstroobants
create rollup transaction for every validator
9184749
@kstroobants
add function to mock in consensus test
6daee80
@kstroobants
feat: add appeal window, accepted queue, basic test
90ea2c1
@kstroobants
fix: old tests were stuck on accepted state, add usage of thread
bb30590
@kstroobants
refactor consensus into states
1e1958c
@kstroobants
feat: added appeal flow when transaction is accepted including the lo…
2708f13 
…op when appeal failed and succeeded
@kstroobants
fix: adding tests for appeals and fixing minor bugs
e3fffde
@kstroobants
refactor: merge main and PR #573 into this branch
3d00e34
@kstroobants
feat: add appeal_failed in db, select new validators when appealed ba…
f5c3af1 
…sed on formula
@kstroobants
docs: cleanup consensus mechanism base file
27624bb
@kstroobants
test: checking the number of validators for different appeals
d315fd1
@kstroobants kstroobants self-assigned this Nov 25, 2024
@kstroobants kstroobants linked an issue Nov 25, 2024 that may be closed by this pull request
Appeals: implement sequential appeals fail #604
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
74.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cristiam86 cristiam86 merged commit 839d6ec into main Dec 17, 2024
18 of 19 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 0.31.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiam86 cristiam86 cristiam86 approved these changes

Assignees

@kstroobants kstroobants

Labels
released run-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appeals: implement sequential appeals fail
2 participants
@kstroobants @cristiam86