feat: sim replace frontend rpc calls with genlayerjs #600

denishacquin · 2024-11-13T03:53:43Z

Fixes #580

What

Implemented GenLayer JS in the Studio frontend
Added possibility to return null on get_transaction_by_hash endpoint (was breaking when a server-side tx didn't exist)

Why

To get closer to the actual final implementation and use the correct api's
To fix a bug

Testing done

tested the new feature
tested the bug fix

Decisions made

Removed some functionality that is now covered by the GenLayer JS library (nonces, useWallet hook...)

Checks

I have tested this code
I have reviewed my own PR
I have created an issue for this PR
I have set a descriptive PR title compliant with conventional commits

User facing release notes

Implemented the official GenLayer JS library to handle accounts and transactions in the Studio

codecov · 2024-11-13T03:54:36Z

Codecov Report

Attention: Patch coverage is 30.08850% with 79 lines in your changes missing coverage. Please review.

Project coverage is 18.74%. Comparing base (a1da20d) to head (267c809).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
frontend/src/hooks/useContractQueries.ts	10.71%	25 Missing ⚠️
frontend/src/hooks/useGenlayer.ts	26.47%	25 Missing ⚠️
frontend/src/hooks/useShortAddress.ts	5.55%	17 Missing ⚠️
frontend/src/components/Simulator/AccountItem.vue	0.00%	4 Missing ⚠️
frontend/src/components/Simulator/ContractInfo.vue	0.00%	3 Missing ⚠️
frontend/src/hooks/useSetupStores.ts	25.00%	3 Missing ⚠️
...rontend/src/components/Simulator/AccountSelect.vue	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   19.45%   18.74%   -0.71%     
==========================================
  Files         129      129              
  Lines        9968     9907      -61     
  Branches      317      307      -10     
==========================================
- Hits         1939     1857      -82     
- Misses       7944     7965      +21     
  Partials       85       85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

denishacquin · 2024-11-13T03:58:06Z

@cristiam86 any hint on how to use leaderonly functionality with GenLayer JS?

cristiam86 · 2024-11-13T14:15:54Z

@cristiam86 any hint on how to use leaderonly functionality with GenLayer JS?

sure, to use it in GenLayerJS, it should be implemented there :D
yeagerai/genlayer-js#24

…ayerjs # Conflicts: # frontend/src/components/Simulator/ContractInfo.vue # frontend/src/hooks/index.ts # frontend/src/hooks/useSetupStores.ts # frontend/src/stores/transactions.ts # frontend/test/unit/stores/transactions.test.ts

…ayerjs # Conflicts: # frontend/src/hooks/index.ts

denishacquin · 2024-11-19T07:02:21Z

Regarding the leaderOnly feature, I've been trying to implement it in genlayer-js, without success until now.

If I dare ask, how important is that feature? Won't it have to be removed once we hook the studio to the real chain? @cristiam86

cristiam86 · 2024-11-19T08:55:21Z

Regarding the leaderOnly feature, I've been trying to implement it in genlayer-js, without success until now.

If I dare ask, how important is that feature? Won't it have to be removed once we hook the studio to the real chain? @cristiam86

Let's take a look together whenever you can :) This is going to be available permanently in the localnet. Of course, it won't be available in the testnet or mainnet.
In Ethereum and other L1s, there are some methods that can be only used in the localnet and they make it easy to force situations or to speed up the development.

…ayerjs

frontend/src/hooks/useContractQueries.ts

denishacquin · 2024-11-20T04:30:34Z

Note that if we want to support the leaderOnly param in this PR, we need to merge the feature in genlayer-js then update the dependency here. @cristiam86

…ayerjs # Conflicts: # frontend/src/hooks/useContractQueries.ts

…ayerjs

cristiam86 · 2024-11-28T09:31:15Z

Oh, sure, sorry, my bad.
@kp2pml30 can we go ahead refactoring this in the frontend with the new schema?

kp2pml30 · 2024-11-28T09:37:46Z

Sorry, I don't understand the question...

Current abi has types in frontend/src/types/index.ts

then these types are used in frontend/src/components/Simulator/ConstructorParameters.vue and frontend/src/components/Simulator/ContractMethodItem.vue

denishacquin · 2024-11-28T10:38:46Z

Ok, then we simply need to update the ContractSchema type in genlayer-js to match the one in the studio.

denishacquin · 2024-11-28T10:57:32Z

Created an issue on the genlayer-js side, will take care of it:
yeagerai/genlayer-js#33

cristiam86

Great work, but we need to merge this one first: yeagerai/genlayer-js#35 and update the leader_only parameter here.

denishacquin · 2024-12-02T08:15:13Z

Great work, but we need to merge this one first: yeagerai/genlayer-js#35 and update the leader_only parameter here.

Went ahead and merged but turns out we forgot a couple - fixed here: #6 please review @cristiam86

As soon as it's released in 0.4.6 I'll bump the version here again!

…ayerjs

sonarqubecloud · 2024-12-04T09:45:28Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

denishacquin

leader only was updated on both sides

denishacquin

leader only ok

github-actions · 2024-12-05T08:03:45Z

🎉 This PR is included in version 0.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Den added 8 commits November 6, 2024 17:15

install genlayer js

2d9ddfc

contract queries OK

12f635c

get transaction with genlayer client

5913705

update transaction unit tests

bcefe89

accounts and client working

4154bf4

extract shorten address hook, update unit tests

219bb9f

cleanup todos

2f7471e

cleanup

eeb0788

denishacquin linked an issue Nov 13, 2024 that may be closed by this pull request

SIM-Replace frontend RPC calls with GenlayerJS #580

Closed

cleanup comments

bdfb79e

denishacquin self-assigned this Nov 13, 2024

Den added 2 commits November 14, 2024 19:03

Merge branch 'main' into 580-sim-replace-frontend-rpc-calls-with-genl…

c5b9951

…ayerjs # Conflicts: # frontend/src/hooks/index.ts

fix pkg lock

3372694

Den added 3 commits November 19, 2024 16:35

allow returning null tx

110719a

update params for leader only

7c577d3

Merge branch 'main' into 580-sim-replace-frontend-rpc-calls-with-genl…

b5df725

…ayerjs

denishacquin marked this pull request as ready for review November 19, 2024 13:59

denishacquin requested a review from cristiam86 November 19, 2024 13:59

cristiam86 requested changes Nov 19, 2024

View reviewed changes

frontend/src/hooks/useContractQueries.ts Outdated Show resolved Hide resolved

frontend/src/hooks/useContractQueries.ts Outdated Show resolved Hide resolved

update genlayer-js and use new contract schema methods

525c8e2

Den and others added 3 commits November 20, 2024 15:32

bump genlayer-js version to include support for leaderOnly param

4c967a7

Merge branch 'main' into 580-sim-replace-frontend-rpc-calls-with-genl…

5c1d938

…ayerjs # Conflicts: # frontend/src/hooks/useContractQueries.ts

Merge branch 'main' into 580-sim-replace-frontend-rpc-calls-with-genl…

267c809

…ayerjs

fix typing with genlayer-js/genvm

2f6945d

denishacquin marked this pull request as draft November 28, 2024 10:57

Den added 4 commits November 28, 2024 20:54

update genlayer-js

334e121

fix cleanup local tx logic

b6a650d

fix unit test

9298ea5

remove redundant typing and use genlayer-js types as truth

709674e

denishacquin marked this pull request as ready for review November 28, 2024 14:14

fix precommit

d4fc374

cristiam86 requested changes Nov 29, 2024

View reviewed changes

Den added 3 commits December 2, 2024 14:44

bump genlayer-js version

ec9996f

update leaderOnly casing in contract queries

a68d306

regen package lock

cb68a39

Den added 3 commits December 2, 2024 15:18

Merge branch 'main' into 580-sim-replace-frontend-rpc-calls-with-genl…

95041de

…ayerjs

Merge branch 'main' into 580-sim-replace-frontend-rpc-calls-with-genl…

2228f71

…ayerjs

bumb genlayer-js version

48f4ae1

denishacquin requested a review from cristiam86 December 2, 2024 09:33

Merge branch 'main' into 580-sim-replace-frontend-rpc-calls-with-genl…

cad1e11

…ayerjs

denishacquin commented Dec 4, 2024

View reviewed changes

cristiam86 approved these changes Dec 4, 2024

View reviewed changes

denishacquin commented Dec 4, 2024

View reviewed changes

cristiam86 merged commit ff5fcb7 into main Dec 4, 2024
28 of 33 checks passed

denishacquin deleted the 580-sim-replace-frontend-rpc-calls-with-genlayerjs branch December 4, 2024 09:53

github-actions bot added the released label Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: sim replace frontend rpc calls with genlayerjs #600

feat: sim replace frontend rpc calls with genlayerjs #600

denishacquin commented Nov 13, 2024 •

edited

Loading

codecov bot commented Nov 13, 2024 •

edited

Loading

denishacquin commented Nov 13, 2024

cristiam86 commented Nov 13, 2024 •

edited

Loading

denishacquin commented Nov 19, 2024

cristiam86 commented Nov 19, 2024

denishacquin commented Nov 20, 2024

cristiam86 commented Nov 28, 2024

kp2pml30 commented Nov 28, 2024 •

edited

Loading

denishacquin commented Nov 28, 2024

denishacquin commented Nov 28, 2024 •

edited

Loading

cristiam86 left a comment

denishacquin commented Dec 2, 2024

sonarqubecloud bot commented Dec 4, 2024

denishacquin left a comment

denishacquin left a comment

github-actions bot commented Dec 5, 2024

feat: sim replace frontend rpc calls with genlayerjs #600

feat: sim replace frontend rpc calls with genlayerjs #600

Conversation

denishacquin commented Nov 13, 2024 • edited Loading

What

Why

Testing done

Decisions made

Checks

User facing release notes

codecov bot commented Nov 13, 2024 • edited Loading

Codecov Report

denishacquin commented Nov 13, 2024

cristiam86 commented Nov 13, 2024 • edited Loading

denishacquin commented Nov 19, 2024

cristiam86 commented Nov 19, 2024

denishacquin commented Nov 20, 2024

cristiam86 commented Nov 28, 2024

kp2pml30 commented Nov 28, 2024 • edited Loading

denishacquin commented Nov 28, 2024

denishacquin commented Nov 28, 2024 • edited Loading

cristiam86 left a comment

Choose a reason for hiding this comment

denishacquin commented Dec 2, 2024

sonarqubecloud bot commented Dec 4, 2024

Quality Gate failed

denishacquin left a comment

Choose a reason for hiding this comment

denishacquin left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2024

denishacquin commented Nov 13, 2024 •

edited

Loading

codecov bot commented Nov 13, 2024 •

edited

Loading

cristiam86 commented Nov 13, 2024 •

edited

Loading

kp2pml30 commented Nov 28, 2024 •

edited

Loading

denishacquin commented Nov 28, 2024 •

edited

Loading