Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make getter functions input parameters mandatory #493

Merged

Conversation

denishacquin
Copy link
Contributor

Fixes #289

What

  • Forces to fill parameters in read methods
image image

Why

  • to improve UX

Testing done

  • tested the new feature
  • tested e2e

Decisions made

  • Disabled the button and added tooltip when some parameters are missing, rather than adding an error.

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

Nothing special.

User facing release notes

  • Read method parameters are now mandatory in order to improve user experience.

@denishacquin denishacquin self-assigned this Sep 11, 2024
@denishacquin denishacquin linked an issue Sep 11, 2024 that may be closed by this pull request
@denishacquin denishacquin marked this pull request as ready for review September 11, 2024 11:40
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 17.88%. Comparing base (c4c2d77) to head (a4d1ff6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nd/src/components/Simulator/ContractMethodItem.vue 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   17.90%   17.88%   -0.02%     
==========================================
  Files         111      111              
  Lines        7955     7963       +8     
  Branches      191      191              
==========================================
  Hits         1424     1424              
- Misses       6456     6464       +8     
  Partials       75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denishacquin denishacquin merged commit 997e401 into main Sep 13, 2024
15 checks passed
Copy link
Contributor

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@denishacquin denishacquin deleted the 289-sim-fe-make-getter-functions-input-parameters-mandatory branch September 16, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIM-FE-Make getter functions input parameters mandatory
2 participants