Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rpc endpoints #481

Merged
merged 25 commits into from
Sep 12, 2024
Merged

refactor: rpc endpoints #481

merged 25 commits into from
Sep 12, 2024

Conversation

denishacquin
Copy link
Contributor

@denishacquin denishacquin commented Sep 6, 2024 •
edited
Loading

Fixes #432

What

  • Removed create_account endpoint
  • Removed send_transaction endpoint
  • Renamed get_contract_state endpoint to call
  • Implemented data encoding and standardized params of call endpoint to match Ethereum spec
  • Remove unused RPC method in the frontend

Why

  • to match the Eth spec
  • to remove unused logic

Testing done

  • tested the call methods
  • unit tests OK
  • e2e tests OK

Decisions made

  • Removed unnecessary RPC method in frontend
  • Refactored some methods and naming in integration tests

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

User facing release notes

  • Normalized implementation of RPC call method to match Ethereum specs

@denishacquin denishacquin self-assigned this Sep 6, 2024
@denishacquin denishacquin linked an issue Sep 6, 2024 that may be closed by this pull request
Refactor RPC endpoints #432
Closed
@denishacquin denishacquin changed the title 432 refactor rpc endponts refactor: rpc endpoints Sep 6, 2024
@denishacquin denishacquin marked this pull request as ready for review September 9, 2024 10:27
fix: Merge branch 'staging' into 432-refactor-rpc-endponts
4505e11 
# Conflicts:
#	backend/protocol_rpc/commands.py
#	backend/protocol_rpc/endpoints.py
@denishacquin
Copy link
Contributor Author

Fixed merge commits

cristiam86
cristiam86 previously approved these changes Sep 10, 2024
View reviewed changes
@cristiam86 cristiam86 deleted the branch main September 11, 2024 09:57
@cristiam86 cristiam86 closed this Sep 11, 2024
@cristiam86 cristiam86 reopened this Sep 11, 2024
@cristiam86 cristiam86 changed the base branch from staging to main September 11, 2024 10:02
@cristiam86 cristiam86 dismissed their stale review September 11, 2024 10:02

The base branch was changed.

cristiam86
cristiam86 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@cristiam86 cristiam86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job

@denishacquin denishacquin merged commit f4de409 into main Sep 12, 2024
15 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@denishacquin denishacquin deleted the 432-refactor-rpc-endponts branch September 16, 2024 09:17
@cristiam86 cristiam86 mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiam86 cristiam86 cristiam86 approved these changes

Assignees

@denishacquin denishacquin

Labels
released
Projects
None yet
Milestone
Align RPC With Proper Definition
Development

Successfully merging this pull request may close these issues.

Refactor RPC endpoints
2 participants
@denishacquin @cristiam86