Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated contributing #421

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

cristiam86
Copy link
Collaborator

Fixes #416

What

  • Added new considerations and workflow practices to the contributing guide
  • Adapted some of the existing sections to include new practices.

Why

  • To improve the way we explain to others how to contribute in the project

Testing done

  • Not needed

Decisions made

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set the PR name to the issue name

Reviewing tips

Read it and give feedback

User facing release notes

Updated the contributing guide to explain some new practices we have adopted to improve the development process.

@cristiam86 cristiam86 linked an issue Sep 2, 2024 that may be closed by this pull request
Copy link
Contributor

@denishacquin denishacquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny grammar thing, otherwise LGTM :)

CONTRIBUTING.md Outdated

To contribute to feature development or bug fixes. Check our [issue tracker](https://github.com/yeagerai/genlayer-simulator/issues) for tasks labeled `help wanted`.
#### 1. Setup yourself to start coding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set yourself up

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@cristiam86 cristiam86 merged commit 8a107aa into staging Sep 2, 2024
22 of 23 checks passed
@cristiam86 cristiam86 deleted the 416-sim-update-contributing branch September 4, 2024 10:30
@github-actions github-actions bot mentioned this pull request Sep 4, 2024
cristiam86 added a commit that referenced this pull request Sep 4, 2024
## What's Changed
* feat: various frontend improvements by @denishacquin in
#418
* fix: 409 sim fe alow horizontal scroll when there is syntax error in
the contract by @denishacquin in
#430
* ci: gh action to validate pr title by @AgustinRamiroDiaz in
#429
* refactor: refactor services and clients by @denishacquin in
#419
* docs: updated contributing by @cristiam86 in
#421
* feat: 417 sim fe allow re ordering contract tabs by dragging them
around by @denishacquin in
#434
* test: 425 frontend unit testing by @denishacquin in
#426
* chore(backend): refactor database connector to use sqlalchemy by
@AgustinRamiroDiaz in
#420
* chore(github): update PR template by @AgustinRamiroDiaz in
#457


**Full Changelog**:
v0.3.2...0.4.0
AgustinRamiroDiaz pushed a commit that referenced this pull request Sep 9, 2024
* docs: updated contributing

* fix: grammar typo
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIM-Update contributing
2 participants