remove Dynamic annotation #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvamelichev
requested changes
Dec 2, 2024
There was a problem hiding this comment.
LGTM 👍
Only a minor change needed: commit message (sentence capitalization + add formatting + a little more details):
- current:
remove Dynamic annotation
- suggested:
Remove unused `@Dynamic` annotation
Better support for multiple tables
with the same Schema is underway.
Better support for multiple tables with the same Schema is underway.
lavrukov
force-pushed
the
remove-dynamic
branch
from
2b5caae
to
85a8360
Compare
|
squash commits and change comment. |
nvamelichev
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look per commit:
1: remove Dynamic annotation
2: simple move of constructor to constructors block (without changes)
3: add this. for fields initialization (without logic change)