Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassCastException during initial schema check #95

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Eistern
Copy link
Contributor

@Eistern Eistern commented Nov 26, 2024

In the scope of this PR, we will fix ClassCastException that happens due to column types being marked as NOT NULL

@nvamelichev
Copy link
Collaborator

nvamelichev commented Nov 26, 2024

Hi! Good catch! 👍

But please remember that YOJ was not written to work with NOT NULL columns, so you might need to also tune the YdbSchemaCompatibilityChecker, error handling in YdbValidator (to handle "value cannot be null" errors from YDB) and also code generation in all of YqlStatement implementations etc. These fixes should be done in other PRs, of course.

@nvamelichev nvamelichev merged commit 12db3e6 into ydb-platform:main Nov 26, 2024
1 check passed
@nvamelichev
Copy link
Collaborator

@Eistern @OlegOAndreev Do you need a release with this fix ASAP? Do you need a backport to YOJ 2.5.x series (because YOJ 2.6.x had a major refactoring in filter expression handling, and Cloud Java is unlikely to have migrated to 2.6.x already)?

@OlegOAndreev
Copy link

It would be nice to have this backported to 2.5.x, yup.

@nvamelichev
Copy link
Collaborator

nvamelichev commented Nov 26, 2024

Fix has been backported to 2.5.10, the new version should appear on Maven Central in the following hours.

https://github.com/ydb-platform/yoj-project/releases/tag/v2.5.10
https://central.sonatype.com/search?q=tech.ydb.yoj&sort=published

@Eistern Eistern deleted the fix-for-not-null branch November 26, 2024 12:39
@Eistern
Copy link
Contributor Author

Eistern commented Dec 2, 2024

Hi @nvamelichev,

Thank you for handling the backport! I've noticed that version 2.5.10 isn't available on Maven Central yet. Could there be an issue with the release pipeline?

The action (https://github.com/ydb-platform/yoj-project/actions/runs/12030357956) shows as completed successfully. However, I see that it doesn't include a commit ID and version in the description, unlike the previous runs. Could you please check if everything went as expected?

Thank you!

@nvamelichev
Copy link
Collaborator

Maybe the 2.5.x branch did not have the changes to release staged artifacts immediately. I'll look into it.

@nvamelichev
Copy link
Collaborator

@Eistern ✔️ I've rebuilt v2.5.10 and released the staging repository to Maven Central. It should appear in a few hours.

@nvamelichev
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants