-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Snapshot-read-only isolation support #79
Conversation
We'll need a basic test: just check that saving an entity in serializable RW mode and then reading in a snapshot transaction works. Please add this to
(Don't forget to Otherwise LGTM 👍 |
b984de4
to
09dcd24
Compare
You can read more about this type of isolation here https://ydb.tech/docs/en/concepts/transactions#modes
09dcd24
to
8b22e65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! 👍
@jorki02 Sorry, but I have to revert this changes. SnapshotRO - it's isolation level similar to serializableRw, but with additional validation. It means that this transactions have to be commited, but txManager.readOnly() don't do it. If you don't do it, YDB will close transactions for you due to a timeout, but if 10 transactions are opened within one session, new ones will no longer be able to be opened. This feature should be added by create new method txManager.snapshotRo() |
@lavrukov Hi, why do you think that it is not committed on readOnly? |
Oh, I see it's committed, but not committed) |
You can read more about this type of isolation here https://ydb.tech/docs/en/concepts/transactions#modes