Skip to content

Commit

Permalink
Docs: Git.io deprecation - Replace links (WordPress#40734)
Browse files Browse the repository at this point in the history
  • Loading branch information
Soean authored May 10, 2022
1 parent 326e178 commit ecd6327
Show file tree
Hide file tree
Showing 21 changed files with 35 additions and 35 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/rnmobile-android-runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
- uses: reactivecircus/android-emulator-runner@5de26e4bd23bf523e8a4b7f077df8bfb8e52b50e # v2.19.1
with:
api-level: 28
emulator-build: 7425822 # https://git.io/JE3jX
emulator-build: 7425822 # https://github.com/ReactiveCircus/android-emulator-runner/issues/160#issuecomment-868615730
profile: pixel_xl
script: npm run native test:e2e:android:local ${{ matrix.native-test-name }}

Expand Down
2 changes: 1 addition & 1 deletion bin/plugin/commands/test/fixtures/pull-requests.json
Original file line number Diff line number Diff line change
Expand Up @@ -6628,7 +6628,7 @@
"diff_url": "https://github.com/WordPress/gutenberg/pull/33788.diff",
"patch_url": "https://github.com/WordPress/gutenberg/pull/33788.patch"
},
"body": "## Description\r\nReact Native added a `PROJECT_ROOT` [configuration to better support monorepos](https://git.io/JBwVr). Prior to setting the `PROJECT_ROOT` configuration, building the Demo app in Xcode threw errors related to the inability to find the entry `index.js` file, as it was searching in the root directory.\r\n\r\n<details><summary>Error Text</summary>\r\n\r\n```\r\nerror The resource `/Users/username/Sites/a8c/gutenberg/index.js` was not found.\r\nError: The resource `/Users/username/Sites/a8c/gutenberg/index.js` was not found.\r\n at /Users/username/Sites/a8c/gutenberg/node_modules/metro/src/IncrementalBundler.js:457:26\r\n at gotStat (node:fs:2627:21)\r\n at FSReqCallback.oncomplete (node:fs:195:21)\r\ninfo Run CLI with --verbose flag for more details.\r\nCommand PhaseScriptExecution failed with a nonzero exit code\r\n```\r\n\r\n</details>\r\n\r\n<details><summary>Error Screenshot</summary>\r\n\r\n<img width=\"1552\" alt=\"xcode-demo-app-error\" src=\"https://user-images.githubusercontent.com/438664/127712716-eb2fd3a3-0444-45be-a4d5-8ada20d22579.png\">\r\n\r\n</details>\r\n\r\n## How has this been tested?\r\n1. Check out `trunk` branch. \r\n2. `npm run native start:reset`\r\n3. Launch Xcode and build the Demo app to a physical device. \r\n4. ⚠️ **Unexpected:** Notice the build failure. \r\n5. Check out this PR branch. \r\n6. `npm run native start:reset`\r\n7. Launch Xcode and build the Demo app to a physical device. \r\n8. ℹ️ **Expected:** The build succeeds and runs on the device. \r\n\r\n## Screenshots <!-- if applicable -->\r\n\r\n## Types of changes\r\nBug fix\r\n\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/javascript/ -->\r\n- [x] My code follows the accessibility standards. <!-- Guidelines: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/accessibility/ -->\r\n- [ ] I've tested my changes with keyboard and screen readers. <!-- Instructions: https://github.com/WordPress/gutenberg/blob/HEAD/docs/contributors/accessibility-testing.md -->\r\n- [x] My code has proper inline documentation. <!-- Guidelines: https://developer.wordpress.org/coding-standards/inline-documentation-standards/javascript/ -->\r\n- [x] I've included developer documentation if appropriate. <!-- Handbook: https://developer.wordpress.org/block-editor/ -->\r\n- [x] I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all `*.native.js` files for terms that need renaming or removal). <!-- React Native mobile Gutenberg guidelines: https://github.com/WordPress/gutenberg/blob/HEAD/docs/contributors/code/native-mobile.md -->\r\n",
"body": "## Description\r\nReact Native added a `PROJECT_ROOT` [configuration to better support monorepos](https://github.com/facebook/react-native/commit/9ccde378b6e6379df61f9d968be6346ca6be7ead). Prior to setting the `PROJECT_ROOT` configuration, building the Demo app in Xcode threw errors related to the inability to find the entry `index.js` file, as it was searching in the root directory.\r\n\r\n<details><summary>Error Text</summary>\r\n\r\n```\r\nerror The resource `/Users/username/Sites/a8c/gutenberg/index.js` was not found.\r\nError: The resource `/Users/username/Sites/a8c/gutenberg/index.js` was not found.\r\n at /Users/username/Sites/a8c/gutenberg/node_modules/metro/src/IncrementalBundler.js:457:26\r\n at gotStat (node:fs:2627:21)\r\n at FSReqCallback.oncomplete (node:fs:195:21)\r\ninfo Run CLI with --verbose flag for more details.\r\nCommand PhaseScriptExecution failed with a nonzero exit code\r\n```\r\n\r\n</details>\r\n\r\n<details><summary>Error Screenshot</summary>\r\n\r\n<img width=\"1552\" alt=\"xcode-demo-app-error\" src=\"https://user-images.githubusercontent.com/438664/127712716-eb2fd3a3-0444-45be-a4d5-8ada20d22579.png\">\r\n\r\n</details>\r\n\r\n## How has this been tested?\r\n1. Check out `trunk` branch. \r\n2. `npm run native start:reset`\r\n3. Launch Xcode and build the Demo app to a physical device. \r\n4. ⚠️ **Unexpected:** Notice the build failure. \r\n5. Check out this PR branch. \r\n6. `npm run native start:reset`\r\n7. Launch Xcode and build the Demo app to a physical device. \r\n8. ℹ️ **Expected:** The build succeeds and runs on the device. \r\n\r\n## Screenshots <!-- if applicable -->\r\n\r\n## Types of changes\r\nBug fix\r\n\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/javascript/ -->\r\n- [x] My code follows the accessibility standards. <!-- Guidelines: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/accessibility/ -->\r\n- [ ] I've tested my changes with keyboard and screen readers. <!-- Instructions: https://github.com/WordPress/gutenberg/blob/HEAD/docs/contributors/accessibility-testing.md -->\r\n- [x] My code has proper inline documentation. <!-- Guidelines: https://developer.wordpress.org/coding-standards/inline-documentation-standards/javascript/ -->\r\n- [x] I've included developer documentation if appropriate. <!-- Handbook: https://developer.wordpress.org/block-editor/ -->\r\n- [x] I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all `*.native.js` files for terms that need renaming or removal). <!-- React Native mobile Gutenberg guidelines: https://github.com/WordPress/gutenberg/blob/HEAD/docs/contributors/code/native-mobile.md -->\r\n",
"performed_via_github_app": null
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const defaultRenderToggle = ( {
extraProps={ {
hint: __( 'Double tap to add a block' ),
// testID is present to disambiguate this element for native UI tests. It's not
// usually required for components. See: https://git.io/JeQ7G.
// usually required for components. See: https://github.com/WordPress/gutenberg/pull/18832#issuecomment-561411389.
testID: 'add-block-button',
onLongPress,
} }
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/hooks/anchor.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export const withInspectorControl = createHigherOrderComponent(
* We plan to remove scoping anchors to 'core/heading' to support
* anchors for all eligble blocks. Additionally we plan to explore
* leveraging InspectorAdvancedControls instead of a custom
* PanelBody title. https://git.io/Jtcov
* PanelBody title. https://github.com/WordPress/gutenberg/issues/28363
*/ }
{ ! isWeb && props.name === 'core/heading' && (
<InspectorControls>
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/block/test/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ describe( 'Reusable block', () => {
} );

// Skipped until `pointerEvents: 'none'` no longer erroneously prevents
// triggering `onLayout*` on the element: https://git.io/JSHZt.
// triggering `onLayout*` on the element: https://github.com/callstack/react-native-testing-library/issues/897.
it.skip( 'renders block content', async () => {
// We have to use different ids because entities are cached in memory.
const id = 4;
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/cover/controls.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ function Controls( {
} );
setDisplayPlaceholder( false );
// Avoid invisible, paused video on Android, presumably
// related to https://git.io/Jt6Dr
// related to https://github.com/react-native-video/react-native-video/issues/1979
videoRef?.current.seek( 0 );
} }
ref={ videoRef }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function FocalPointSettingsButton( {
>
{ /*
* Wrapper View element used around Icon as workaround for SVG opacity
* issue: https://git.io/JtuXD
* issue: https://github.com/react-native-svg/react-native-svg/issues/1345
*/ }
<View style={ disabled && styles.dimmedActionButton }>
<Icon icon={ chevronRight } />
Expand Down
14 changes: 7 additions & 7 deletions packages/block-library/src/image/test/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ describe( 'Image Block', () => {

fireEvent.press( screen.getByA11yLabel( /Image Block/ ) );
// Awaiting navigation event seemingly required due to React Navigation bug
// https://git.io/Ju35Z
// https://github.com/react-navigation/react-navigation/issues/9701
await act( () =>
fireEvent.press( screen.getByA11yLabel( 'Open Settings' ) )
);
Expand All @@ -113,7 +113,7 @@ describe( 'Image Block', () => {

fireEvent.press( screen.getByA11yLabel( /Image Block/ ) );
// Awaiting navigation event seemingly required due to React Navigation bug
// https://git.io/Ju35Z
// https://github.com/react-navigation/react-navigation/issues/9701
await act( () =>
fireEvent.press( screen.getByA11yLabel( 'Open Settings' ) )
);
Expand All @@ -139,7 +139,7 @@ describe( 'Image Block', () => {

fireEvent.press( screen.getByA11yLabel( /Image Block/ ) );
// Awaiting navigation event seemingly required due to React Navigation bug
// https://git.io/Ju35Z
// https://github.com/react-navigation/react-navigation/issues/9701
await act( () =>
fireEvent.press( screen.getByA11yLabel( 'Open Settings' ) )
);
Expand Down Expand Up @@ -172,7 +172,7 @@ describe( 'Image Block', () => {

fireEvent.press( screen.getByA11yLabel( /Image Block/ ) );
// Awaiting navigation event seemingly required due to React Navigation bug
// https://git.io/Ju35Z
// https://github.com/react-navigation/react-navigation/issues/9701
await act( () =>
fireEvent.press( screen.getByA11yLabel( 'Open Settings' ) )
);
Expand Down Expand Up @@ -212,7 +212,7 @@ describe( 'Image Block', () => {

fireEvent.press( screen.getByA11yLabel( /Image Block/ ) );
// Awaiting navigation event seemingly required due to React Navigation bug
// https://git.io/Ju35Z
// https://github.com/react-navigation/react-navigation/issues/9701
await act( () =>
fireEvent.press( screen.getByA11yLabel( 'Open Settings' ) )
);
Expand All @@ -239,7 +239,7 @@ describe( 'Image Block', () => {

const settingsButton = screen.getByA11yLabel( 'Open Settings' );
// Awaiting navigation event seemingly required due to React Navigation bug
// https://git.io/Ju35Z
// https://github.com/react-navigation/react-navigation/issues/9701
await act( () => fireEvent.press( settingsButton ) );

const linkTargetButton = screen.getByText( 'Open in new tab' );
Expand Down Expand Up @@ -270,7 +270,7 @@ describe( 'Image Block', () => {

const settingsButton = screen.getByA11yLabel( 'Open Settings' );
// Awaiting navigation event seemingly required due to React Navigation bug
// https://git.io/Ju35Z
// https://github.com/react-navigation/react-navigation/issues/9701
await act( () => fireEvent.press( settingsButton ) );

const linkTargetButton = screen.getByText( 'Open in new tab' );
Expand Down
6 changes: 3 additions & 3 deletions packages/components/src/focal-point-picker/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ function FocalPointPicker( props ) {
// coordinates to workaround a bug affecting Android's PanResponder.
// Specifically, dragging the handle outside the bounds of the image
// results in inaccurate locationX and locationY coordinates to be
// reported. https://git.io/JtWmi
// reported. https://github.com/facebook/react-native/issues/15290#issuecomment-435494944
const x = pageX - locationPageOffsetX;
const y = pageY - locationPageOffsetY;
onChange( {
Expand All @@ -116,7 +116,7 @@ function FocalPointPicker( props ) {
} );
// Slider (child of RangeCell) is uncontrolled, so we must increment a
// key to re-mount and sync the pan gesture values to the sliders
// https://git.io/JTe4A
// https://github.com/callstack/react-native-slider/tree/v3.0.3#value
setSliderKey( ( prevState ) => prevState + 1 );
},
} ),
Expand Down Expand Up @@ -193,7 +193,7 @@ function FocalPointPicker( props ) {
setVideoNaturalSize( { height, width } );
setDisplayPlaceholder( false );
// Avoid invisible, paused video on Android, presumably related to
// https://git.io/Jt6Dr
// https://github.com/react-native-video/react-native-video/issues/1979
videoRef?.current.seek( 0 );
};
const onXCoordinateChange = ( x ) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const BottomSheetNavigationScreen = ( {
* Ideally, we refactor onHandleHardwareButtonPress to manage multiple
* callbacks triggered based upon which screen is currently active.
*
* Related: https://git.io/JD2no
* Related: https://github.com/WordPress/gutenberg/pull/36328#discussion_r768897546
*/
}, [] )
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ it( 'animates height transitioning from full-screen to non-full-screen', async (
);
// Navigate to screen 1
fireEvent.press(
// Use custom waitFor due to https://git.io/JYYGE
// Use custom waitFor due to https://github.com/callstack/react-native-testing-library/issues/379
await waitFor( () => screen.getByText( /test-screen-2/ ) )
);
// Await navigation screen to allow async state updates to complete
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class BottomSheet extends Component {
// TODO: Reinstate animations, possibly replacing `LayoutAnimation` with
// more nuanced `Animated` usage or replacing our custom `BottomSheet`
// with `@gorhom/bottom-sheet`. This animation was disabled to avoid a
// preexisting bug: https://git.io/JMPCV
// preexisting bug: https://github.com/WordPress/gutenberg/issues/30562
// this.performRegularLayoutAnimation( {
// useLastLayoutAnimation: false,
// } );.
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/sandbox/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const style = `
/**
* Add responsiveness to embeds with aspect ratios.
*
* These styles have been copied from the web version (https://git.io/JEFcX) and
* These styles have been copied from the web version (https://github.com/WordPress/gutenberg/blob/7901895ca20cf61e402925e31571d659dab64721/packages/block-library/src/embed/style.scss#L42-L89) and
* adapted for the native version.
*/
.wp-has-aspect-ratio.wp-block-embed__wrapper::before {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/tooltip/test/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ it( 'displays the message', () => {
} );

// Skipped until `pointerEvents: 'box-none'` no longer erroneously prevents
// triggering `onTouch*` on the element: https://git.io/JSHZt
// triggering `onTouch*` on the element: https://github.com/callstack/react-native-testing-library/issues/897
it.skip( 'dismisses when the screen is tapped', () => {
const screen = render(
<TooltipSlot>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ it( 'navigates back from help topic detail screen', async () => {
const backButton = screen.getAllByA11yLabel( 'Go back' );
fireEvent.press( backButton[ backButton.length - 1 ] );

// Currently logs `act` warning due to https://git.io/JYYGE
// Currently logs `act` warning due to https://github.com/callstack/react-native-testing-library/issues/379
await waitForElementToBeRemoved( () =>
screen.getByText(
'Each block has its own settings. To find them, tap on a block. Its settings will appear on the toolbar at the bottom of the screen.'
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-editor/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ target 'GutenbergDemo' do
# Let Pods targets inherit deployment target from the app
# This solution is suggested here: https://github.com/CocoaPods/CocoaPods/issues/4859
installer.pods_project.targets.each do |target|
# Exclude RCT-Folly as it requires explicit deployment target https://git.io/JPb73
# Exclude RCT-Folly as it requires explicit deployment target https://github.com/facebook/flipper/issues/834#issuecomment-899725463
if (target.name != 'RCT-Folly')
target.build_configurations.each do |configuration|
pod_ios_deployment_target = Gem::Version.new(configuration.build_settings['IPHONEOS_DEPLOYMENT_TARGET'])
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native-editor/metro.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ module.exports = {
* within this project to include the necessary `/assets/..` that Metro's
* server expects to traverse to the correct directory.
*
* - https://git.io/JBV4e
* - https://git.io/JBFon
* - https://github.com/facebook/metro/issues/290
* - https://github.com/expo/expo/issues/7545#issuecomment-712737616
*/
const firstUrlSegment = req.url.split( '/' )[ 1 ];
if ( packageNames.includes( firstUrlSegment ) ) {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native-editor/src/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ const reactNativeSetup = () => {
* TODO: Migrate to @gorhom/bottom-sheet or replace usage of
* LayoutAnimation to Animated. KeyboardAvoidingView's usage of
* LayoutAnimation collides with both BottomSheet and NavigationContainer
* usage of LayoutAnimation simultaneously https://git.io/J1lZv,
* https://git.io/J1lZY
* usage of LayoutAnimation simultaneously https://github.com/facebook/react-native/issues/12663,
* https://github.com/facebook/react-native/issues/10606
*/
'Overriding previous layout animation',
] );
Expand Down
10 changes: 5 additions & 5 deletions packages/react-native-editor/src/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe( 'Register Gutenberg', () => {
jest.isolateModules( () => render( <EditorComponent /> ) );

// "invocationCallOrder" can be used to compare call orders between different mocks.
// Reference: https://git.io/JyBk0
// Reference: https://github.com/facebook/jest/issues/4402#issuecomment-534516219
const setupLocaleCallOrder = setupLocale.mock.invocationCallOrder[ 0 ];
const onSetupImportedCallOrder =
mockOnModuleImported.mock.invocationCallOrder[ 0 ];
Expand All @@ -79,7 +79,7 @@ describe( 'Register Gutenberg', () => {
jest.isolateModules( () => render( <EditorComponent /> ) );

// "invocationCallOrder" can be used to compare call orders between different mocks.
// Reference: https://git.io/JyBk0
// Reference: https://github.com/facebook/jest/issues/4402#issuecomment-534516219
const beforeInitCallOrder =
beforeInitCallback.mock.invocationCallOrder[ 0 ];
const onSetupImportedCallOrder =
Expand Down Expand Up @@ -108,7 +108,7 @@ describe( 'Register Gutenberg', () => {

const hookCallIndex = 0;
// "invocationCallOrder" can be used to compare call orders between different mocks.
// Reference: https://git.io/JyBk0
// Reference: https://github.com/facebook/jest/issues/4402#issuecomment-534516219
const hookCallOrder =
doAction.mock.invocationCallOrder[ hookCallIndex ];
const onRenderEditorCallOrder =
Expand Down Expand Up @@ -139,7 +139,7 @@ describe( 'Register Gutenberg', () => {

const hookCallIndex = 0;
// "invocationCallOrder" can be used to compare call orders between different mocks.
// Reference: https://git.io/JyBk0
// Reference: https://github.com/facebook/jest/issues/4402#issuecomment-534516219
const hookCallOrder =
applyFilters.mock.invocationCallOrder[ hookCallIndex ];
const onRenderEditorCallOrder =
Expand Down Expand Up @@ -170,7 +170,7 @@ describe( 'Register Gutenberg', () => {

const hookCallIndex = 1;
// "invocationCallOrder" can be used to compare call orders between different mocks.
// Reference: https://git.io/JyBk0
// Reference: https://github.com/facebook/jest/issues/4402#issuecomment-534516219
const hookCallOrder =
doAction.mock.invocationCallOrder[ hookCallIndex ];
const onRenderEditorCallOrder =
Expand Down
2 changes: 1 addition & 1 deletion test/native/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export async function initializeEditor( props, { component } = {} ) {

export * from '@testing-library/react-native';

// Custom implementation of the waitFor utility to prevent the issue: https://git.io/JYYGE.
// Custom implementation of the waitFor utility to prevent the issue: https://github.com/callstack/react-native-testing-library/issues/379.
export function waitFor(
cb,
{ timeout, interval } = { timeout: 1000, interval: 50 }
Expand Down
Loading

0 comments on commit ecd6327

Please sign in to comment.