update

yangyongyongyong · Apr 14, 2023 · b4cbcba · b4cbcba
1 parent f1bf0df
commit b4cbcba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/readme/array/udf/array.md b/readme/array/udf/array.md
@@ -31,9 +31,9 @@ create temporary function array_intersect as "org.thomas.hive.udf.ArrayIntersect
 -- select array_intersect(`array`(5,1,2,8),`array`(2,3,5,7),`array`(5,8)); -- array 交集
     -- [5]
 
-create temporary function array_index_of as "org.thomas.hive.udf.ArrayIndexOfUDF";
--- select array_index_of(`array`(11,22,33,44),33); -- 返回指定元素在数组列中的index. index从0开始. 不存在则返回 -1
-    -- 2
+create temporary function array_position as "org.thomas.hive.udf.ArrayIndexOfUDF";
+-- select array_position(`array`(11,22,33,44),33); -- 返回指定元素在数组列中的index. index从0开始. 不存在则返回 -1
+    -- 3
 
 create temporary function array_remove as 'org.thomas.hive.udf.ArrayRemove';
 -- select array_remove(`array`(11,22,33,22,100),22,100);

diff --git a/src/main/java/org/thomas/hive/udf/ArrayIndexOfUDF.java b/src/main/java/org/thomas/hive/udf/ArrayIndexOfUDF.java
@@ -82,7 +82,8 @@ public Object evaluate(DeferredObject[] arguments) throws HiveException {
             Object listElement = arrayOI.getListElement(array, i);
             if (listElement != null) {
                 if (ObjectInspectorUtils.compare(value, valueOI, listElement, arrayElementOI) == 0) {
-                    result.set(i);
+                    // 这里和spark同名函数保持一致逻辑  返回的index从1开始
+                    result.set(i+1);
                     break;
                 }
             }
@@ -94,6 +95,6 @@ public Object evaluate(DeferredObject[] arguments) throws HiveException {
     @Override
     public String getDisplayString(String[] children) {
         assert (children.length == ARG_COUNT);
-        return "array_index_of(" + children[ARRAY_IDX] + ", " + children[VALUE_IDX] + ")";
+        return "array_position(" + children[ARRAY_IDX] + ", " + children[VALUE_IDX] + ")";
     }
 }