Close replica on partitioning to prevent its returning online but lagging #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vicpopov
commented
Nov 5, 2024
vicpopov
commented
- Remember time of each successful replica report to ZK.
- If ZK is unavailable, check if walreceiver is streaming.
- If both ZK and walreceiver checks fail, close replica.
- Log everything with values that triggered this logic.
- Add tests for this logic.
vicpopov
force-pushed
the
detached_replica_close
branch
3 times, most recently
from
2452dfa
to
f19dfeb
Compare
munakoiso
requested changes
Nov 7, 2024
…ging - Remember time of each successful replica report to ZK. - If ZK is unavailable, check if walreceiver is streaming. - If both ZK and walreceiver checks fail, close replica. - Log everything with values that triggered this logic. - Add tests for this logic.
vicpopov
force-pushed
the
detached_replica_close
branch
from
f19dfeb
to
d377519
Compare
munakoiso
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.