Skip to content

Commit

Permalink
support query string in the path for route matching
Browse files Browse the repository at this point in the history
  • Loading branch information
lingyan committed Oct 24, 2014
1 parent 24f13a5 commit 4ece5dd
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
19 changes: 16 additions & 3 deletions lib/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ Route.prototype.acceptMethod = function (method) {
/**
* Checkes whether this route matches the given path, method (GET as default) and optionally navigation related criteria.
* @method match
* @param {String} path The url path to be matched to this route
* @param {String} path The url path to be matched to this route. Query strings are **not** considered
* when performing the match. E.g. /some_path?foo=bar would match to the same route
* as /some_path
* @param {Object} [options]
* @param {String} [options.method=get] The case-insensitive HTTP method string. Defaults to 'get'.
* @param {Object} [options.navigate] The navigation info.
Expand All @@ -63,8 +65,17 @@ Route.prototype.match = function (path, options) {
pathMatches,
routeParams,
key,
i,
len,
pos,
pattern;

// remove query string from path
pos = path.indexOf('?');
if (pos >= 0) {
path = path.substring(0, pos);
}

options = options || {};

// 1. check method
Expand Down Expand Up @@ -103,7 +114,7 @@ Route.prototype.match = function (path, options) {

// 4. method/path/navParams all matched, extract the matched path params
routeParams = {};
for (var i = 0, len = self.keys.length; i < len; i++) {
for (i = 0, len = self.keys.length; i < len; i++) {
routeParams[self.keys[i].name] = pathMatches[i+1];
}

Expand Down Expand Up @@ -168,7 +179,9 @@ function Router(routes) {

/**
* @method getRoute
* @param {String} path The url path.
* @param {String} path The url path to be used for route matching. Query strings are **not** considered
* when performing the match. E.g. /some_path?foo=bar would match to the same route
* as /some_path
* @param {Object} [options]
* @param {String} [options.method=get] The case-insensitive HTTP method string.
* @param {Object} [options.navigate] The navigation info.
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/lib/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ describe('Router', function () {

route = router.getRoute('/new_article', {method: 'post'});
expect(route.name).to.equal('new_article');

route = router.getRoute('/new_article?foo=bar', {method: 'post'});
expect(route.name).to.equal('new_article');
});

it('method should be case-insensitive and defaults to get', function () {
Expand Down

0 comments on commit 4ece5dd

Please sign in to comment.