Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use importlib-resources over deprecated pkg_resources #51

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 17, 2024

Resolves #50

  • Add importlib-resources as an install dependency for Python 3.8 as Python 3.12 deprecates and removes pkg_resources.
  • Replace use of pkg_resources.resource_filename with importlib.resources.files for Python 3.9+ and importlib_resources.files for Python 3.8.
  • Apply isort.
  • Note import order issue to be fixed.
* Add importlib-resources as an install dependency for Python 3.8 as Python 3.12 deprecates
  and removes pkg_resources.
* Replace use of pkg_resources.resource_filename with importlib.resources.files
  for Python 3.9+ and importlib_resources.files for Python 3.8.
* Apply isort.
* Note import order issue to be fixed.

* Add importlib-resources as an install dependency for Python 3.8 as Python 3.12 deprecates
  and removes pkg_resources.
* Replace use of pkg_resources.resource_filename with importlib.resources.files
  for Python 3.9+ and importlib_resources.files for Python 3.8.
* Apply isort.
@matthewfeickert matthewfeickert force-pushed the fix/remove-pkg_resources branch from 9f12093 to a9c96ba Compare June 17, 2024 16:55
@matthewfeickert matthewfeickert merged commit 1739071 into main Jun 17, 2024
7 checks passed
@matthewfeickert matthewfeickert deleted the fix/remove-pkg_resources branch June 17, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pkg_resources dependency
1 participant