free the cursor #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh hell yeah thanks man |
spenserlee
pushed a commit
to spenserlee/dingllm.nvim
that referenced
this pull request
Aug 24, 2024
Source: <yacineMTB#7>
theloner68
suggested changes
Nov 19, 2024
| @@ -115,8 +110,7 @@ local function get_prompt(opts) | |||
| if visual_lines then | |||
| prompt = table.concat(visual_lines, '\n') | |||
| if replace then | |||
| vim.api.nvim_command 'normal! d' | |||
| vim.api.nvim_command 'normal! k' | |||
| vim.api.nvim_command 'normal! c' | |||
There was a problem hiding this comment.
keep starting position cursor in original start line while replacing fix the fault in VISUAL LINE mode that keep moving starting cursor to wierd place
change vim.api.nvim_command 'normal! c'
to vim.api.nvim_command 'normal! c '
spenserlee
added a commit
to spenserlee/dingllm.nvim
that referenced
this pull request
Dec 13, 2024
Thanks to the original work in: <yacineMTB#7> The cursor wasn't truly free, as if you switch buffers the LLM response stream would error out from invalid extmark changes. Record the buffer ID and pass to data function handler for get extmark and set_text. This should allow for multiple requests to be running concurrently in separate buffers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found a neat way to keep track of the position to stream tokens without forcing the user to keep the cursor in place
i implemented it in my own plugin (chottolabs/kznllm.nvim#9), but it might be useful here too
cursor is stuck:
dingllm_cursor_weird_.mov
cursor is free:
dingllm_cursor_fixed_.mov