-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new-log-viewer: Define interface for filtering by log level and add support (internally) to JsonlDecoder; Move timestamp field extraction from LogbackFormatter to JsonlDecoder. #79
Merged
Merged
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
62a69c7
first draft
davemarco f409855
remove uneccesary format changes
davemarco 3343510
more unneceesary changes
davemarco 434f2f8
add missing functions
davemarco 33da060
latest
davemarco e5b6abe
small changes
davemarco 2ecd5b1
fix linting
davemarco 477fe23
add moved file
davemarco 17c281a
small changes
davemarco da61b98
small changes
davemarco f3cb5b4
small change
davemarco 4159305
Apply suggestions from code review
davemarco 01e4723
add filteredLogEventMap
davemarco dc9e533
forgot this suggestion
davemarco 114af1d
remove 1 type cast
davemarco a2814e4
small changes
davemarco b562c34
Apply suggestions from code review
davemarco 5af877a
junhao/kirk changes
davemarco 8ce2a83
merge
davemarco 4bf08dc
fix lint
davemarco 8d38166
merge commit
davemarco 81389df
change pageNum to useState to fix pageNum occasionaly not updating wh…
davemarco 3777537
revert changes will fix in another PR
davemarco 5933c37
kirk + junhao review
davemarco 637d488
small changes
davemarco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better if we make the log-level filtering a no-op rather than completely disabling the decoder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put in the console error but not the return value. If the value is null, the new plan is it will just not use the filter, so it is okay to return null.