new-log-viewer: Add custom Monaco editor themes and a Monaco language for logs. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhaoliao
commented
Sep 12, 2024
junhaoliao
changed the title
Henry8192
reviewed
Sep 12, 2024
Henry8192
reviewed
Sep 12, 2024
Henry8192
requested changes
Sep 12, 2024
Henry8192
previously approved these changes
Sep 12, 2024
junhaoliao
commented
Sep 13, 2024
| @@ -7,6 +7,17 @@ import * as monaco from "monaco-editor/esm/vs/editor/editor.api.js"; | |||
| import {ACTION_NAME} from "../../../utils/actions"; | |||
|
|
|||
|
|
|||
| enum TOKEN_NAMES { | |||
There was a problem hiding this comment.
Suggested change
| enum TOKEN_NAMES { | |
| enum TOKEN_NAME { |
Plural naming is reserved for arrays.
junhaoliao
commented
Sep 13, 2024
| * Resets the cached page size in case it causes a client OOM. If it doesn't, the saved value | ||
| * will be restored when {@link restoreCachedPageSize} is called. | ||
| */ | ||
| const resetCachedPageSize = () => { |
There was a problem hiding this comment.
this was pulled out from Editor to avoid max lines lint violation.
kirkrodrigues
requested changes
Sep 16, 2024
| /** | ||
| * Sets up custom themes for the Monaco editor. | ||
| */ | ||
| const setupThemes = () => { |
There was a problem hiding this comment.
Minor nit: Grammatically, this should be setUpThemes since setup is a noun, not a verb. Feel free to ignore if you think it's more confusing.
There was a problem hiding this comment.
How about initThemes?
On the other hand, for consistency we should rename the other functions as well. Any objection if we do the renaming in the same PR?
There was a problem hiding this comment.
Mm, that might touch a lot of places. We could leave it as setupXxx for now and do the refactoring in another PR.
new-log-viewer/src/components/Editor/MonacoInstance/language.ts
Outdated
Show resolved
Hide resolved
junhaoliao
requested review from
kirkrodrigues
and removed request for
kirkrodrigues
kirkrodrigues
approved these changes
Sep 16, 2024
junhaoliao
changed the title
This was referenced Sep 16, 2024
This was referenced Sep 27, 2024
This was referenced Sep 30, 2024
This was referenced Oct 14, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
new-log-viewer series: #45 #46 #48 #51 #52 #53 #54 #55 #56 #59 #60 #61 #62 #63 #66 #67 #68
#59 added theming support via JoyUI.
Description
Validation performed