Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch theme from furo to pydata-sphinx-theme. #5

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

kirkrodrigues
Copy link
Member

Description

Following y-scope/clp-ffi-py#49, this PR also switches the theme from furo to pydata-sphinx-theme.

Validation performed

Validated task docs:serve built and served the docs with the new theme.

Copy link
Member

@junhaoliao junhaoliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs website appearance looks good. Some suggestions regarding PEP 8 and name shadowing.

docs/conf.py Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
Copy link
Member

@junhaoliao junhaoliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and title look good.

@kirkrodrigues kirkrodrigues merged commit ef563ac into y-scope:main Mar 18, 2024
@kirkrodrigues kirkrodrigues deleted the switch-theme branch March 18, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants