-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add job implementation and driver start job implementation #43
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4502b58
Add driver start and get jobs
sitaowang1998 38cf91c
Fix clang tidy
sitaowang1998 f3b4d31
Add job get result
sitaowang1998 554310f
Fix JobStatus bug and add basic driver integration test framework
sitaowang1998 4053dff
Fix worker test bug
sitaowang1998 6e0aec8
Add client test program and fix some bugs
sitaowang1998 41a9f0f
Add pytest that runs client test
sitaowang1998 2a9c6f7
Bug fix
sitaowang1998 93cb2b6
Fix clang tidy
sitaowang1998 0e34bc4
Add spider::spider cmake target
sitaowang1998 328af00
Add client_test as a integrationTest dependency
sitaowang1998 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add the missing library alias
According to the summary, an alias
spider::spider
should be defined for thespider_client
library. This alias is missing from the implementation.Add the following after the target_link_libraries block:
+add_library(spider::spider ALIAS spider_client)
📝 Committable suggestion