Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Migrate to ESLint v9. #3
base: main
Are you sure you want to change the base?
feat!: Migrate to ESLint v9. #3
Changes from 44 commits
0f2f6a0
dff69ba
979d00c
0397f42
8eca3d8
ce6cf8d
490fc80
e0fac0e
7c03a71
d877f74
ac0fe90
b8dccee
b9bdc27
762bed7
91de045
87b8fd6
0774e26
1d0d5a0
a5c5fb2
b819542
31f284c
fd12f8c
d03e6fa
a97dc0e
620bc8c
8f0edf6
de3be18
6982ed7
05d00d9
01511c8
24b5826
3602bf5
dc5e5c4
3ac267c
473728e
ab5d839
b576db8
09dbd7f
a1cd2f8
bbc8d56
2f194d4
fb854cd
6be95c8
b343b20
68405ea
ede36ed
8c7173a
f3b3d6a
4a4a353
42418b8
b66f68c
7cb4644
3304e16
fbe33ab
e4b747b
39450ee
46ccf99
d108e36
ce3266f
6aa2e0e
0a759ac
6b59dcf
a25917d
c897715
7d9ba94
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Expand the note about configuration order
The note about placement is crucial but lacks context. Consider expanding it to explain why this ordering is necessary.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for clarity but also could be overly verbose. @kirkrodrigues what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? GitHub already specifies the license, no? If you want to specify the license on npmjs.org, I assume we need to fill out the license field in package.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we don't have to add this into the README
i'll add the license field to the package.json