Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clo: Use relative path for file metadata output by an IR extraction job. #470

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

haiqi96
Copy link
Contributor

@haiqi96 haiqi96 commented Jul 4, 2024

Description

This PR replaces the absolute path in the results cache with relative path. The relative path is preferred because different worker containers may have different mounts, so they may not share the same absolute path.

Validation performed

Manually submitted an IR extraction job and verified that the path in results cache is expected

Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

clo: Use relative path for file metadata output by an IR extraction job.

@haiqi96 haiqi96 changed the title clo: Use relative path for results cache metadata clo: Use relative path for file metadata output by an IR extraction job. Jul 4, 2024
@haiqi96 haiqi96 merged commit 9dabb92 into y-scope:main Jul 4, 2024
13 checks passed
jackluo923 pushed a commit to jackluo923/clp that referenced this pull request Dec 4, 2024
@haiqi96 haiqi96 deleted the relative_path_ir branch December 6, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants