-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Ubuntu Focal gcc-10 setup and update related usage instructions. #371
Conversation
In a Ubuntu Focal distribution where package
After we install |
Yep, I agree. In the upcoming PR to automate the package build, we'll have a container + scripts which install the normal gcc toolchain so that Python packages with C extensions can be installed without issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a clean WSL Ubuntu 20.04.
How about
Refactor Ubuntu Focal gcc-10 setup and update related usage instructions.
Description
In #131, we made GCC v10+ a requirement. Since the default version of GCC on Ubuntu Focal is v9, #131 also added set up steps to configure v10 as the compiler on Focal. However, these steps were flawed:
gcc
andg++
as the names for the alternatives whereas Ubuntu usually setscc
andc++
as the names.cc
andc++
in Reduce the size of the clp container images. #288.update-alternatives --query <program>
where<program>
is one ofcc
,c++
, orcpp
.This PR addresses these limitations:
cc
,c++
, andcpp
(the same alternatives created by the Ubuntu GCC package maintainers, except for GCC v10) as part of the dependency install scripts.gcc
andg++
.Validation performed
cc --version
,c++ --version
and/lib/cpp --version
all print a v10 version string./lib/cpp
based on the alternative that the Ubuntu gcc package usually creates (seels /etc/alternatives
).