Add missing outputs field when referring to the lowered repository names.
#275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkrodrigues
approved these changes
Feb 11, 2024
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
GitHub action failed: https://github.com/y-scope/clp/actions/runs/7862011912
Description
In PR (#273), the change was incorrect since there is a missing
outputs.field when referring to the repository name generated insanitization. It was not exposed because, during the development, the actual workflow that instantiates the workflow was never executed. This PR fixes the problem.Validation performed
In my forked repo, I manually enabled both workflows to ensure the docker names can be properly generated (
"linzhihao-723").