Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 22.04 execution container; Use machine's architecture name for local builds. #264

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

haiqi96
Copy link
Contributor

@haiqi96 haiqi96 commented Feb 5, 2024

Description

  1. let the naming of the container image to be platform specific
  2. Added ubuntu 22.04 build script

Validation performed

Manually confirmed container names are generated properly
Confirmed that arm container runs on arm64 machine on aws.

Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: Add Ubuntu 22.04 execution container; Use machine's architecture name for local builds. (#264)?

@haiqi96 haiqi96 changed the title Add 22.04 support to execution container and enable platform specific flow Add Ubuntu 22.04 execution container; Use machine's architecture name for local builds. (#264) Feb 5, 2024
@haiqi96 haiqi96 changed the title Add Ubuntu 22.04 execution container; Use machine's architecture name for local builds. (#264) Add Ubuntu 22.04 execution container; Use machine's architecture name for local builds. Feb 5, 2024
@haiqi96 haiqi96 merged commit 51df592 into y-scope:main Feb 5, 2024
2 checks passed
@haiqi96 haiqi96 deleted the arm_container_build branch February 6, 2024 01:51
haiqi96 added a commit to haiqi96/clp_fork that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants