-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clp-s: Add support for sending search results to MongoDB. #230
Merged
kirkrodrigues
merged 11 commits into
y-scope:main
from
wraymo:muslope_send_to_results_cache
Jan 19, 2024
Merged
clp-s: Add support for sending search results to MongoDB. #230
kirkrodrigues
merged 11 commits into
y-scope:main
from
wraymo:muslope_send_to_results_cache
Jan 19, 2024
+250
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraymo
force-pushed
the
muslope_send_to_results_cache
branch
from
January 12, 2024 19:48
c2d8b71
to
1794c9e
Compare
wraymo
force-pushed
the
muslope_send_to_results_cache
branch
from
January 18, 2024 21:27
293c380
to
0dfb8ba
Compare
kirkrodrigues
requested changes
Jan 18, 2024
kirkrodrigues
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the commit message, how about:
clp-s: Add support for sending search results to MongoDB. (#230)
Looks good to me
…On Fri, Jan 19, 2024 at 00:32 kirkrodrigues ***@***.***> wrote:
***@***.**** approved this pull request.
For the commit message, how about:
clp-s: Add support for sending search results to MongoDB. (#230)
—
Reply to this email directly, view it on GitHub
<#230 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI4LBM6BOEUTUZKJZK4AIH3YPIAP7AVCNFSM6AAAAABBYTTS5KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZRGYYDGMBYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
davidlion
approved these changes
Jan 19, 2024
kirkrodrigues
changed the title
Add MongoDB output support for clp-s search
clp-s: Add support for sending search results to MongoDB.
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#223
Description
#223 added supports for sending query results to results_cache (MongoDB) for clp package. This PR added MongoDB output support for clp-s binary. We will integrate clp-s with the package and allow user to choose between clp and clp-s in the upcoming PR.
Validation performed