Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clp-s: Add support for sending search results to MongoDB. #230

Merged
merged 11 commits into from
Jan 19, 2024

Conversation

wraymo
Copy link
Contributor

@wraymo wraymo commented Jan 12, 2024

References

#223

Description

#223 added supports for sending query results to results_cache (MongoDB) for clp package. This PR added MongoDB output support for clp-s binary. We will integrate clp-s with the package and allow user to choose between clp and clp-s in the upcoming PR.

Validation performed

  • Successfully compiled the source code
  • Tested search with output to both stdout and MongoDB

@wraymo wraymo force-pushed the muslope_send_to_results_cache branch from c2d8b71 to 1794c9e Compare January 12, 2024 19:48
@wraymo wraymo marked this pull request as draft January 18, 2024 18:45
@wraymo wraymo marked this pull request as ready for review January 18, 2024 20:05
@wraymo wraymo requested a review from kirkrodrigues January 18, 2024 21:12
@wraymo wraymo force-pushed the muslope_send_to_results_cache branch from 293c380 to 0dfb8ba Compare January 18, 2024 21:27
components/core/src/clp_s/search/OutputHandler.hpp Outdated Show resolved Hide resolved
components/core/src/clp_s/search/OutputHandler.hpp Outdated Show resolved Hide resolved
components/core/src/clp_s/search/OutputHandler.hpp Outdated Show resolved Hide resolved
components/core/src/clp_s/CommandLineArguments.cpp Outdated Show resolved Hide resolved
components/core/src/clp_s/CommandLineArguments.cpp Outdated Show resolved Hide resolved
components/core/src/clp_s/search/OutputHandler.hpp Outdated Show resolved Hide resolved
components/core/src/clp_s/CommandLineArguments.cpp Outdated Show resolved Hide resolved
wraymo and others added 6 commits January 18, 2024 18:33
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the commit message, how about:

clp-s: Add support for sending search results to MongoDB. (#230)

@wraymo
Copy link
Contributor Author

wraymo commented Jan 19, 2024 via email

@kirkrodrigues kirkrodrigues merged commit 776fc3a into y-scope:main Jan 19, 2024
5 checks passed
@kirkrodrigues kirkrodrigues changed the title Add MongoDB output support for clp-s search clp-s: Add support for sending search results to MongoDB. Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants