Container image build fixes: #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Error on failure to install any package into the container image. - Don't use an empty array as a command (for older Bash versions).
LinZhihao-723
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent failures to install packages in the CentOS container were not being caught until we tried to build CLP in the container since the script which calls the package install script didn't exit on error. In addition, mongoc and mongocxx were failing to install in the CentOS container since it uses an older version of bash which doesn't support expanding an empty array (it treats it as an unbound variable).
This PR adds error checks in the scripts which call the package install scripts and fixes the mongoc/cxx install scripts to support the older version of bash.
Validation performed