Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting improvements for core component: #201

Merged
merged 5 commits into from
Dec 31, 2023
Merged

Linting improvements for core component: #201

merged 5 commits into from
Dec 31, 2023

Conversation

kirkrodrigues
Copy link
Member

@kirkrodrigues kirkrodrigues commented Dec 31, 2023 •
edited
Loading

  • Add Taskfile rule to apply lint fixes.
  • Add .clang-format to list of files for yamllint to check.
  • Fix .clang-format's yamllint violations.
  • Fix .clang-format rule error.
  • Fix .clang-format regex for C standard library headers.
  • Fix venv generation so activate remains valid.

Description

This PR mainly adds a convenient rule to apply core's lint fixes and reformats the .clang-format file.

Validation performed

  • Validated the fix and check rules work.
  • Validated the lint workflow still works.

@kirkrodrigues
Lint improves for core component:
369597f 
- Add rule to apply lint fixes.
- Fix .clang-format's yamllint violations.
- Fix .clang-format rule error.
@kirkrodrigues
Add .clang-format to list of files for yamllint to check.
fa55ab8
@kirkrodrigues kirkrodrigues changed the title Lint improvements for core component: Linting improvements for core component: Dec 31, 2023
@kirkrodrigues kirkrodrigues merged commit 4124824 into y-scope:main Dec 31, 2023
5 checks passed
@kirkrodrigues kirkrodrigues deleted the core-lint-improve branch December 31, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlion davidlion davidlion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirkrodrigues @davidlion