Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure string_utils into a library. #200

Merged
merged 10 commits into from
Dec 31, 2023

Conversation

kirkrodrigues
Copy link
Member

@kirkrodrigues kirkrodrigues commented Dec 30, 2023

Description

We are starting to properly modularize CLP into a set of libraries and executables rather than one monolithic source directory. This PR converts the string_utils.* files into a string_utils library.

Some things to note:

  • Instead of placing everything in the clp namespace, we are splitting out functionality that is not CLP-specific into its own namespace. This is to:
    • avoid heavily nested namespaces (see TotW 130), and
    • allow other projects to rely on the general functionality from this repo.
      • We will try to avoid conflicts with popular 3rd-party libraries, but (as usual) it will be up to the users of the CLP repo to ensure they are not using a namespace which conflicts with the ones in the CLP repo.
      • We can eventually split libraries into their own repos as necessary.
  • The string_utils library doesn't have its CMake install command set up. We will likely address all the install settings in a PR after the complete restructure (these PRs are meant to be iterative given the magnitude of the change we're making).

Validation performed

  • Built successfully.
  • Unit tests passed.

Copy link
Member

@davidlion davidlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to verbose include/string_utils/string_utils.hpp.

components/core/src/ir/LogEventDeserializer.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@haiqi96 haiqi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kirkrodrigues kirkrodrigues merged commit abda9a3 into y-scope:main Dec 31, 2023
5 checks passed
@kirkrodrigues kirkrodrigues deleted the restructure-1 branch December 31, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants