Bug-fix: Don't use pointers to elements in an actively modified vector during query processing. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraymo
changed the title
wraymo
force-pushed
the
relevant_query_bug_fix
branch
from
7427d08 to
40754e9
Compare
wraymo
changed the title
kirkrodrigues
requested changes
Dec 20, 2023
kirkrodrigues
requested changes
Dec 21, 2023
kirkrodrigues
approved these changes
Dec 21, 2023
kirkrodrigues
changed the title
kirkrodrigues
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Previously, when we push new elements into
m_relevant_sub_queries, we usem_relevant_sub_queries.push_back(&m_sub_queries.back());. However,m_sub_queriesis a vector and the memory is dynamically allocated. Upon resizing, it may use new addresses and pointers stored inm_relevant_sub_queriesare no longer valid.Validation performed
Passed unit test and clang-format check. Also ran queries which cover the affected code and got expected results