-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the 8-byte long timestamp delta encoding #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinZhihao-723
force-pushed
the
ts_delta_extend
branch
from
September 24, 2023 08:34
c276cf9
to
33e57b7
Compare
kirkrodrigues
requested changes
Sep 28, 2023
kirkrodrigues
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally we should try to do unrelated formatting changes in another PR so that the changes in this PR concisely match their purpose, but it's not worth changing things back for this one.
Co-authored-by: kirkrodrigues <[email protected]>
kirkrodrigues
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current IR encoding protocol doesn't support 8-byte timestamp delta encoding. This means the current four-byte encoding IR stream cannot contain a timestamp delta of more than +/- 24.86 days. This PR resolves this problem by introducing an 8-byte timestamp delta encoding.
The protocol version number is bumped to "v0.0.1". As a result, the version of the decoder must have been up-to-date to decode an 8-byte encoded timestamp delta properly.
To validate the version, a validation function is added to check whether the built protocol version number is greater or equal to the input protocol version number. The current version validation relies on the SemVar https://semver.org/#backusnaur-form-grammar-for-valid-semver-versions convention.
Validation performed