Skip to content

Commit

Permalink
Done
Browse files Browse the repository at this point in the history
  • Loading branch information
LinZhihao-723 committed Dec 9, 2024
1 parent 091791d commit bef61cd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ namespace clp::ffi::ir_stream {
* @param user_gen_keys_schema_tree Schema tree for user-generated keys, used to construct the
* KV-pair log event.
* @param utc_offset UTC offset used to construct the KV-pair log event.
* @return A result containing the deserialized log event or an error code indicating the
* failure:
* @return A result containing the deserialized log event or an error code indicating the failure:
* - std::errc::result_out_of_range if the IR stream is truncated.
* - std::errc::protocol_error if the IR stream is corrupted.
* - std::errc::protocol_not_supported if the IR stream contains an unsupported metadata format
Expand Down
2 changes: 0 additions & 2 deletions components/core/tests/test-ffi_KeyValuePairLogEvent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,6 @@ TEST_CASE("ffi_KeyValuePairLogEvent_create", "[ffi]") {
REQUIRE_NOTHROW(user_gen_keys_schema_tree->insert_node(locator));
}

// This test case implicitly requires the auto-generated and user-generated schema trees to
// be identical. Adding this check to prevent this assumption is broken by future development.
REQUIRE((*auto_gen_keys_schema_tree == *user_gen_keys_schema_tree));

SECTION("Test empty ID-value pairs") {
Expand Down

0 comments on commit bef61cd

Please sign in to comment.