feat: Add support for key-value pair IR format serialization and deserialization. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkrodrigues
requested changes
Nov 15, 2024
| ":param buffer_size_limit: Threshold of how much serialized data to buffer before flushing" | ||
| " it to `output_stream`. Defaults to 64 KiB.\n" | ||
| ":type buffer_size_limit: int\n" | ||
| ":rtype: int\n" |
There was a problem hiding this comment.
Leaving a comment so I remember to check this.
| ":param allow_incomplete_stream: If set to `True`, an incomplete CLP IR stream is not" | ||
| " treated as an error.\n" | ||
| ":type allow_incomplete_stream: bool\n" | ||
| ":rtype: int\n" |
Co-authored-by: kirkrodrigues <[email protected]>
Co-authored-by: kirkrodrigues <[email protected]>
kirkrodrigues
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This PR adds support for key-value pair IR format serialization and deserialization:
Serializerfor IR serializationDeserializerfor IR deserializationKeyValuePairLogEventfor storing deserialized log eventsValidation performed
Debugbuild in Python 3.10 debug build + address sanitizer, ensure no errors/warnings caused by our implementation