Refactor source files to move towards latest coding standard: #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlion
reviewed
Jul 8, 2024
src/clp_ffi_py/ExceptionFFI.hpp
Outdated
Comment on lines
1
to
2
| #ifndef CLP_FFI_PY_IR_EXCEPTION_FFI | ||
| #define CLP_FFI_PY_IR_EXCEPTION_FFI |
There was a problem hiding this comment.
This change seems incorrect no? (same with the endif)
davidlion
approved these changes
Jul 8, 2024
davidlion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This PR refactors source files to meet our latest coding guidelines.
.incfiles and move the implementation into the header files.Validation performed