-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linting: Always use latest versions of linting tools; Upgrade clang-format config. #61
Conversation
I ran tests and linters with no errors. |
It may make sense to add -U to |
It is expected to run with a virtual env so upgrade is not necessarily needed |
I know clp uses poetry, but not sure if the github action linter uses the lock file from the package. It is probably overkill for this repo. I am okay with as is |
Makes sense |
Sorry I didn't quite get this comment... |
just bringing the linters will auto update for the action, which could cause the workflow to fail even if it ran fine locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the same PR title we used in y-scope/clp?
sure |
References
Description
The current code base was formatted by out-dated linting tools. When running gh workflow, linting check will fail. This PR has the following updates:
Note: ideally, we can drop the versions specified in
requirements-dev.txt
to ensure it always uses the latest one. However, adding the version there would help us keep track of which version of the config file we used to setup these linting tools.Validation performed