Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ruff lint settings into tool.ruff.lint. #54

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Move ruff lint settings into tool.ruff.lint. #54

merged 1 commit into from
Mar 17, 2024

Conversation

LinZhihao-723
Copy link
Member

References

Description

When running the latest version of ruff, it will send the following warnings:

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'select' -> 'lint.select'
  - 'isort' -> 'lint.isort

This PR solves the warning by updating the ruff settings in pyproject.toml.

Validation performed

  1. Running ruff locally without warnings.
  2. Workflow passed.

kirkrodrigues
kirkrodrigues approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Move ruff lint settings into tool.ruff.lint. (#54)

@LinZhihao-723
Copy link
Member Author

How about:

Move ruff lint settings into tool.ruff.lint. (#54)

lgtm

@LinZhihao-723 LinZhihao-723 changed the title Update ruff config in the project setting. Move ruff lint settings into tool.ruff.lint. Mar 17, 2024
@LinZhihao-723 LinZhihao-723 merged commit af051e6 into y-scope:main Mar 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinZhihao-723 @kirkrodrigues