Add support to skip forward when decoding IR streams #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remind me, what was the conclusion we reached for this PR? |
|
This PR should be no longer needed, as it's functionality should be handled by the query in nature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the decoder doesn't support skipping forward. Users have to decode and discard log events when needed manually. This PR enables forward skipping by introducing a new method to decode and discard a certain amount of log events from the given IR stream.
This PR also refactors the implementation of the decoding method to template the termination of a decoding process. This provides a function interface to reuse decoding logic and implement query search decoding, sequential decoding, and forward skipping.
Validation performed