Add linter checks and unit testing to Github Workflow. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinZhihao-723
changed the title
davidlion
approved these changes
Nov 28, 2023
LinZhihao-723
changed the title
davidlion
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, GitHub workflow does not enforce linter checks and unit testing. This PR adds support to enhance our current GitHub workflow.
Changes made:
docformatter,black,ruff, andmypy.clang-tidyis not included because it cannot be installed throughpip.setup.cfgto specify project dependencies. This is required for Python3.6 becausepyproject.tomlstarted being supported from Python3.7.clang-format. After discussing with @kirkrodrigues we decided to leave what it is for now, but I have fired an issue to clang-format to see if they can help fix it.cibuildwheelto execute unit tests for the built wheels under the target environment (platform and architecture). The configure is specified inpyproject.toml. Detailed doc can be found here. Notice that currently onlyPython3.6,Python3.8, andPython3.11are tested.