Replace memcpy with std::copy to avoid undefined behaviour when buffers overlap. #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current implementation, the code uses
memcpy
to copy the unconsumed bytes from the end of the buffer to the beginning. In most cases, this is safe because the previousif
statement handles the cases where more than half of bytes in the current buffer are unconsumed. However, the corner case happens when the number of unconsumed bytes is larger than half of the actual buffer size (not the capacity). If this happens, the behavior of the code depends on the underlyingmemcpy
implementation. This PR solves this UB by replacingmemcpy
withstd::copy
, so it will be safe even if the src and dst buffers overlap.Notice that there will be a performance drop with the changes in this PR since
std::copy
cannot optimizegsl::span
. However, this problem will be fix after switching to C++20 withstd::span
.