Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the CLP dependency to the lastest main branch commit #29

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Update the CLP dependency to the lastest main branch commit #29

merged 6 commits into from
Nov 6, 2023

Conversation

LinZhihao-723
Copy link
Member

Description

Update the CLP dependency to use the latest features implemented in the CLP core. This includes:

  1. Use BufferReader to decode log events
  2. Add protocol version validation when decoding the metadata to ensure the input ir stream is supported with the current library version.

Validation performed

  1. Passed all the unit tests.
  2. Passed all the C++ linters.

kirkrodrigues
kirkrodrigues requested changes Nov 5, 2023
View reviewed changes
MANIFEST.in Show resolved Hide resolved
src/clp_ffi_py/ir/native/decoding_methods.cpp Outdated Show resolved Hide resolved
src/clp_ffi_py/ir/native/decoding_methods.cpp Show resolved Hide resolved
@kirkrodrigues kirkrodrigues merged commit a4439d8 into y-scope:main Nov 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinZhihao-723 @kirkrodrigues