refactor: Fix clang-tidy warnings in Query.

[LinZhihao-723]

Description

This is one of the PR series trying to implement #96.
This PR fixes all clang-tidy warnings in Query.

Validation performed

• Ensure all workflows passed.

Summary by CodeRabbit

• Chores

  • Updated static code analysis configuration to include new source files for linting
  • Modernized C++ code by updating header includes and using ranges-based algorithm

• Refactor

  • Simplified wildcard query matching implementation using C++ ranges

The changes focus on improving code quality and maintainability without altering core functionality.

[coderabbitai]

Walkthrough

This pull request introduces modifications to the linting configuration and source files for the C++ project. The changes primarily involve expanding the static code analysis coverage by adding two new source files, Query.cpp and Query.hpp, to the cpp-static-check task in the lint-tasks.yml file. Additionally, the Query.cpp file has been updated to use the modern C++ ranges-based algorithm, and header dependencies in Query.hpp have been adjusted.

Changes

File	Change Summary
.github/workflows/lint-tasks.yml	Added Query.cpp and Query.hpp to SRC_PATHS for static code analysis
src/clp_ffi_py/ir/native/Query.cpp	Replaced std::any_of with std::ranges::any_of for wildcard query matching
src/clp_ffi_py/ir/native/Query.hpp	Replaced <clp/ffi/encoding_methods.hpp> with <clp/ir/types.hpp>, added <utility> header

Possibly related issues

• Fix clang-tidy warnings for all C++ source files #96: Fix clang-tidy warnings for all C++ source files
  • This PR contributes to the gradual resolution of clang-tidy warnings by including new files in the static analysis process

Possibly related PRs

• refactor: Fix clang-tidy warnings in PyKeyValuePairLogEvent. #108: Modifies lint-tasks.yml to add new source files for static analysis
• refactor: Fix clang-tidy warnings in PySerializer. #110: Adds new source files to the cpp-static-check task
• refactor: Fix clang-tidy warnings in PyDeserializer. #111: Expands static analysis coverage by adding source files

Suggested reviewers

• haiqi96

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83794f9 and b58202c.

📒 Files selected for processing (3)

• lint-tasks.yml (1 hunks)
• src/clp_ffi_py/ir/native/Query.cpp (1 hunks)
• src/clp_ffi_py/ir/native/Query.hpp (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• src/clp_ffi_py/ir/native/Query.hpp
• src/clp_ffi_py/ir/native/Query.cpp

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: linters

🔇 Additional comments (1)

lint-tasks.yml (1)

130-131: LGTM! The changes align with the PR objectives.

The addition of Query.cpp and Query.hpp to the clang-tidy check list is consistent with the goal of fixing clang-tidy warnings in the Query component.

Let's verify the existence of these files:

✅ Verification successful

Files verified: Both Query.cpp and Query.hpp exist in the expected directory

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the added files exist in the repository

# Test: Check if the files exist
fd -t f "Query\.(cpp|hpp)$" "src/clp_ffi_py/ir/native"

Length of output: 198

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[haiqi96]

lgtm