refactor: Fix clang-tidy warnings in PyLogEvent and LogEvent to a…

…lign with the latest C++ coding guideline. (#118)
y-scope · Jan 12, 2025 · f40737c · f40737c
1 parent 301b510
commit f40737c
Show file tree

Hide file tree

Showing 4 changed files with 343 additions and 315 deletions.
diff --git a/lint-tasks.yml b/lint-tasks.yml
@@ -117,12 +117,15 @@ tasks:
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ExceptionFFI.hpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/DeserializerBufferReader.cpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/DeserializerBufferReader.hpp"
+            - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/LogEvent.hpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PyDeserializer.cpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PyDeserializer.hpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PyDeserializerBuffer.cpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PyDeserializerBuffer.hpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PyKeyValuePairLogEvent.cpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PyKeyValuePairLogEvent.hpp"
+            - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PyLogEvent.cpp"
+            - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PyLogEvent.hpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PyQuery.cpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PyQuery.hpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ir/native/PySerializer.cpp"

diff --git a/src/clp_ffi_py/ir/native/LogEvent.hpp b/src/clp_ffi_py/ir/native/LogEvent.hpp
@@ -1,9 +1,12 @@
 #ifndef CLP_FFI_PY_IR_NATIVE_LOG_EVENT_HPP
 #define CLP_FFI_PY_IR_NATIVE_LOG_EVENT_HPP
 
+#include <cstddef>
 #include <optional>
+#include <string>
+#include <string_view>
 
-#include <clp/ffi/encoding_methods.hpp>
+#include <clp/ir/types.hpp>
 
 namespace clp_ffi_py::ir::native {
 /**