Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: kirkrodrigues <[email protected]>
  • Loading branch information
LinZhihao-723 and kirkrodrigues authored Dec 2, 2024
1 parent 7f920a6 commit a92a0f3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ jobs:

- uses: "actions/setup-python@v5"
with:
# NOTE: CPython3.10 headers are used to resolve clang-tidy warnings
# NOTE: We resolve some of clang-tidy's IWYU violations using CPython 3.10's headers, so
# we need to use the same version of Python when running clang-tidy.
python-version: "3.10"

- run: |
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ in the table below.
| `lint:cpp-fix` | Runs the C++ linters and fixes some violations. |
| `lint:cpp-format-check` | Runs the C++ formatters. |
| `lint:cpp-format-fix` | Runs the C++ formatters and fixes some violations. |
| `lint:cpp-static-check` | Runs the C++ linters. |
| `lint:cpp-static-check` | Runs the C++ static analyzers. |
| `lint:py-check` | Runs the Python linters. |
| `lint:py-fix` | Runs the Python linters and fixes some violations. |
| `lint:yml-check` | Runs the YAML linters. |
Expand Down
6 changes: 3 additions & 3 deletions lint-tasks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ vars:
G_LINT_VENV_CHECKSUM_FILE: "{{.BUILD_DIR}}/lint#venv.md5"
# Linter target dirs
G_CPP_LINT_DIRS:
# TODO: before all clang-tidy warnings are resolved, we should maintain a list of files that
# doesn't have clang-tidy warnings, so that clang-tidy can be executed in the limited scope
# without failing existing workflows.
# TODO: Before all clang-tidy violations are resolved, we should only run clang-tidy on the
# files whose violations we've fixed, both to ensure they remain free of violations and so that
# the workflow doesn't fail due to violations in other files.
- "{{.CLP_FFI_PY_CPP_SRC_DIR}}/Py_utils.cpp"
- "{{.CLP_FFI_PY_CPP_SRC_DIR}}/Py_utils.hpp"
G_PYTHON_LINT_DIRS: ["{{.ROOT_DIR}}/clp_ffi_py", "{{.ROOT_DIR}}/tests"]
Expand Down

0 comments on commit a92a0f3

Please sign in to comment.