Skip to content

Commit

Permalink
Code review
Browse files Browse the repository at this point in the history
  • Loading branch information
LinZhihao-723 committed Nov 29, 2023
1 parent 376f55a commit 87d52a8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ color = true
preview = true

[tool.cibuildwheel]
# Use `musllinux_1_2` to support C++20 compilation
musllinux-aarch64-image = "musllinux_1_2"
musllinux-i686-image = "musllinux_1_2"
musllinux-ppc64le-image = "musllinux_1_2"
musllinux-s390x-image = "musllinux_1_2"
musllinux-x86_64-image = "musllinux_1_2"

skip = "pp*"

test-command = [
Expand Down
1 change: 0 additions & 1 deletion src/GSL
Submodule GSL deleted from 430030
2 changes: 1 addition & 1 deletion src/clp_ffi_py/ir/native/PyDecoderBuffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ auto PyDecoderBuffer::populate_read_buffer(Py_ssize_t& num_bytes_read) -> bool {
PyErr_NoMemory();
return false;
}
auto new_read_buffer{std::span<int8_t>(new_buf, new_capacity)};
std::span<int8_t> new_read_buffer{new_buf, static_cast<size_t>(new_capacity)};
std::copy(
unconsumed_bytes_in_curr_read_buffer.begin(),
unconsumed_bytes_in_curr_read_buffer.end(),
Expand Down

0 comments on commit 87d52a8

Please sign in to comment.