Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INP to GA4 with LoAF attribution #126

Merged
merged 17 commits into from
Jun 26, 2024
Merged

Conversation

pereirinha
Copy link
Member

@pereirinha pereirinha commented Jun 6, 2024

Adds support for INP

Tasks

  • Adds INP metrics
  • Bumps Web Vitals to 4+ so that we can leverage the LoAF attribution
  • Removes FID
  • Remove GA3 logic

Describe the Approach

  • Uses the newly added LoAF lib from Web Vitals to collect attribution information

Release Checklist

  • Review the release guidelines in the contribution documentation.
  • Update the plugin Version: header value in site-performance-tracker.php.
  • Confirm that automated tests are passing for this pull request.

@pereirinha pereirinha requested review from kasparsd and mehigh June 6, 2024 08:53
@pereirinha pereirinha force-pushed the feature/ga4-with-attribution branch from 7e60a46 to aad3dff Compare June 6, 2024 09:01
@mehigh
Copy link
Member

mehigh commented Jun 26, 2024

Tested this out, and for the sake of not storing data that's not as useful, I'll trim the delay values to not have decimals after the milliseconds and then will merge it in
Screenshot 2024-06-26 at 12 05 10

@mehigh mehigh merged commit f943153 into master Jun 26, 2024
1 check passed
@mehigh mehigh deleted the feature/ga4-with-attribution branch June 26, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants