Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22184: Change the underlining inline links behavior on a minimal install #3126

Merged
merged 1 commit into from
May 28, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented May 21, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22184

Changes

Description

  • Reduced the specificity of the underlining preference selector so that it's matched even during docker testing.

Clarifications

  • The selector for the underlining preference rules was very specific. In this case it was too specific. It relied on the .content class, which is somehow related only to the state of the columns. In docker tests, there is no side panels, and the .content class is not on the body. This caused the automated tests to unexpectedly sill fail on all the link that were supposed to be fixed by the new underlining defaults. The fix reduces specificity on the style rule. This should not have any negative impact. AFAIR this rule was not here out of necessity, I just added it to avoid matching too wide. I should have considered the origin of the .content class better though.
  • This class was introduced in abcf971 .

Screenshots & Video

None, test change only.

Executed Tests

Ran mvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/ -Pdocker -Dit.test=PageTemplatesIT -Dxwiki.test.ui.wcag=true successfully. The inline links were only reported for the places fixed in this other PR: #3124 .

My expectation is for this change to fix most of the automated tests about link underlining, at least the ~220 occurences of issues that arise with the lastModificationAuthor link (which is the one I checked manually and the one that was overly present in the administration tests) .

Expected merging strategy

* Reduced the specificity of the underlining preference selector so that it's matched even during docker testing.
@surli
Copy link
Member

surli commented May 23, 2024

Reduced the specificity of the underlining preference selector so that it's matched even during docker testing.

Maybe you're doing this for fixing integration test, but it's actually a change in the less file used in XS so I'm not sure I'd do that change as a misc. Also it means that a minimal install (without a flavor) would be impacted (this is what we have in integration test).
So I'm not against the change, but I think we'd probably need a ticket.

@Sereza7 Sereza7 changed the title [Misc] Fixing underlining in tests XWIKI-22184: Change the underlining inline links behavior on a minimal install May 23, 2024
@Sereza7
Copy link
Contributor Author

Sereza7 commented May 23, 2024

👍
I created this Jira ticket and updated the PR topic.
When merging, the commit message should be updated to fit this new status :)

@michitux michitux merged commit 67cad95 into xwiki:master May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants