XWIKI-22184: Change the underlining inline links behavior on a minimal install #3126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22184
Changes
Description
Clarifications
.content
class, which is somehow related only to the state of the columns. In docker tests, there is no side panels, and the .content class is not on the body. This caused the automated tests to unexpectedly sill fail on all the link that were supposed to be fixed by the new underlining defaults. The fix reduces specificity on the style rule. This should not have any negative impact. AFAIR this rule was not here out of necessity, I just added it to avoid matching too wide. I should have considered the origin of the.content
class better though.Screenshots & Video
None, test change only.
Executed Tests
Ran
mvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/ -Pdocker -Dit.test=PageTemplatesIT -Dxwiki.test.ui.wcag=true
successfully. The inline links were only reported for the places fixed in this other PR: #3124 .My expectation is for this change to fix most of the automated tests about link underlining, at least the ~220 occurences of issues that arise with the lastModificationAuthor link (which is the one I checked manually and the one that was overly present in the administration tests) .
Expected merging strategy